From 5f4596578f596860b795b0e951443a59ed8d7742 Mon Sep 17 00:00:00 2001
From: gilles <gillesalbert99@gmail.com>
Date: Tue, 22 Sep 2026 08:39:04 +0200
Subject: [PATCH] =?UTF-8?q?fix(ui):=20directives=20use=20client=20et=20cor?=
 =?UTF-8?q?rectifs=20qualit=C3=A9=20(lint,=20format,=20typecheck,=20tests)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/app/cards/[id]/edit/page.tsx    |  6 +-----
 src/app/cards/[id]/page.tsx         |  6 +-----
 src/components/card-delete.test.tsx |  6 ++++--
 src/components/card-detail.test.tsx |  4 +++-
 src/components/card-detail.tsx      | 23 ++++++++++++++++-------
 src/components/card-form.test.tsx   |  6 ++++--
 src/components/card-form.tsx        |  4 +++-
 src/components/card-list.test.tsx   | 24 ++++++++++++++++++++----
 src/components/card-list.tsx        |  8 +++++++-
 src/lib/api-client.test.ts          | 19 +++++++++++--------
 src/lib/api-client.ts               |  9 +++++++--
 11 files changed, 77 insertions(+), 38 deletions(-)

diff --git a/src/app/cards/[id]/edit/page.tsx b/src/app/cards/[id]/edit/page.tsx
index 7cc784f..da374ea 100644
--- a/src/app/cards/[id]/edit/page.tsx
+++ b/src/app/cards/[id]/edit/page.tsx
@@ -7,11 +7,7 @@ import { ApiClientError, cardsApi } from '@/lib/api-client'
 
 export const metadata: Metadata = { title: 'Modifier la carte' }
 
-export default async function EditCardPage({
-  params,
-}: {
-  params: Promise<{ id: string }>
-}) {
+export default async function EditCardPage({ params }: { params: Promise<{ id: string }> }) {
   const { id } = await params
   let card: Card | null = null
   try {
diff --git a/src/app/cards/[id]/page.tsx b/src/app/cards/[id]/page.tsx
index 40e775e..73fbefa 100644
--- a/src/app/cards/[id]/page.tsx
+++ b/src/app/cards/[id]/page.tsx
@@ -5,11 +5,7 @@ export const metadata: Metadata = {
   title: 'Carte',
 }
 
-export default async function CardDetailPage({
-  params,
-}: {
-  params: Promise<{ id: string }>
-}) {
+export default async function CardDetailPage({ params }: { params: Promise<{ id: string }> }) {
   const { id } = await params
   return (
     <main className="mx-auto max-w-3xl px-4 py-8">
diff --git a/src/components/card-delete.test.tsx b/src/components/card-delete.test.tsx
index 3893b4c..d2f93e4 100644
--- a/src/components/card-delete.test.tsx
+++ b/src/components/card-delete.test.tsx
@@ -1,6 +1,6 @@
 import { render, screen, within } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, expect, it, vi } from 'vitest'
 import { CardDeleteButton } from './card-delete'
 
 vi.mock('@/lib/api-client', () => {
@@ -52,7 +52,9 @@ it('supprime après confirmation puis retourne à la liste (F-07)', async () =>
   vi.mocked(cardsApi.remove).mockResolvedValue(undefined as never)
   render(<CardDeleteButton cardId="c1" question="question-x" />)
   await userEvent.click(screen.getByRole('button', { name: 'Supprimer' }))
-  await userEvent.click(within(screen.getByRole('dialog')).getByRole('button', { name: 'Supprimer' }))
+  await userEvent.click(
+    within(screen.getByRole('dialog')).getByRole('button', { name: 'Supprimer' }),
+  )
   expect(cardsApi.remove).toHaveBeenCalledWith('c1')
   expect(routerMock.push).toHaveBeenCalledWith('/cards')
   expect(routerMock.refresh).toHaveBeenCalled()
diff --git a/src/components/card-detail.test.tsx b/src/components/card-detail.test.tsx
index bff58eb..6c0ad1a 100644
--- a/src/components/card-detail.test.tsx
+++ b/src/components/card-detail.test.tsx
@@ -1,5 +1,5 @@
 import { render, screen } from '@testing-library/react'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, expect, it, vi } from 'vitest'
 import { CardDetail } from './card-detail'
 
 vi.mock('@/lib/api-client', () => {
@@ -27,6 +27,8 @@ const CARD = {
   response: 'Un snapshot du projet',
   theme: 'git',
   tags: ['snapshot'],
+  createdAt: new Date('2026-01-01T08:00:00Z'),
+  updatedAt: new Date('2026-01-01T08:00:00Z'),
 }
 
 beforeEach(() => {
diff --git a/src/components/card-detail.tsx b/src/components/card-detail.tsx
index e04d52e..a6834b6 100644
--- a/src/components/card-detail.tsx
+++ b/src/components/card-detail.tsx
@@ -1,3 +1,5 @@
+'use client'
+
 import Link from 'next/link'
 import { useEffect, useState } from 'react'
 import type { Card } from '@/domain/card'
@@ -25,7 +27,11 @@ export function CardDetail({ cardId }: { cardId: string }) {
   }, [cardId])
 
   if (error) {
-    return <p role="alert" className="text-red-600">{error}</p>
+    return (
+      <p role="alert" className="text-red-600">
+        {error}
+      </p>
+    )
   }
   if (card === null) {
     return <p aria-busy="true">Chargement…</p>
@@ -46,21 +52,24 @@ export function CardDetail({ cardId }: { cardId: string }) {
       {card.tags.length > 0 && (
         <ul className="flex flex-wrap gap-1.5">
           {card.tags.map((tag) => (
-            <li
-              key={tag}
-              className="rounded-full bg-slate-100 px-2 py-0.5 text-xs text-slate-600"
-            >
+            <li key={tag} className="rounded-full bg-slate-100 px-2 py-0.5 text-xs text-slate-600">
               #{tag}
             </li>
           ))}
         </ul>
       )}
       <div className="flex items-center gap-3">
-        <Link href={`/cards/${card.id}/edit`} className="text-sm font-medium text-slate-700 underline-offset-4 hover:underline">
+        <Link
+          href={`/cards/${card.id}/edit`}
+          className="text-sm font-medium text-slate-700 underline-offset-4 hover:underline"
+        >
           Modifier
         </Link>
         <span className="text-slate-300">·</span>
-        <Link href="/cards" className="text-sm font-medium text-slate-700 underline-offset-4 hover:underline">
+        <Link
+          href="/cards"
+          className="text-sm font-medium text-slate-700 underline-offset-4 hover:underline"
+        >
           Retour à la liste
         </Link>
       </div>
diff --git a/src/components/card-form.test.tsx b/src/components/card-form.test.tsx
index 6631281..70ba592 100644
--- a/src/components/card-form.test.tsx
+++ b/src/components/card-form.test.tsx
@@ -1,10 +1,12 @@
 import { render, screen } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, expect, it, vi } from 'vitest'
 import { CardForm } from './card-form'
 
 vi.mock('@/lib/api-client', () => ({
-  ApiClientError: class extends Error { status = 0 },
+  ApiClientError: class extends Error {
+    status = 0
+  },
   cardsApi: { create: vi.fn(), update: vi.fn() },
 }))
 
diff --git a/src/components/card-form.tsx b/src/components/card-form.tsx
index 903d0e4..ddae030 100644
--- a/src/components/card-form.tsx
+++ b/src/components/card-form.tsx
@@ -43,7 +43,9 @@ export function CardForm({ mode, cardId, initial }: CardFormProps) {
   return (
     <form onSubmit={handleSubmit} className="space-y-4">
       {error && (
-        <p role="alert" className="text-red-600">{error}</p>
+        <p role="alert" className="text-red-600">
+          {error}
+        </p>
       )}
       <div>
         <label htmlFor="question" className="block text-sm font-medium text-slate-700">
diff --git a/src/components/card-list.test.tsx b/src/components/card-list.test.tsx
index cd8f0f4..02178a4 100644
--- a/src/components/card-list.test.tsx
+++ b/src/components/card-list.test.tsx
@@ -1,5 +1,5 @@
 import { render, screen, within } from '@testing-library/react'
-import { describe, expect, it, vi, beforeEach } from 'vitest'
+import { expect, it, vi, beforeEach } from 'vitest'
 import { CardList } from './card-list'
 
 vi.mock('@/lib/api-client', () => {
@@ -22,8 +22,24 @@ vi.mock('@/lib/api-client', () => {
 import { cardsApi, ApiClientError } from '@/lib/api-client'
 
 const CARDS = [
-  { id: '1', question: 'Cest quoi un commit ?', response: 'Un snapshot du projet', theme: 'git', tags: [], createdAt: new Date().toISOString(), updatedAt: new Date().toISOString() },
-  { id: '2', question: 'Cest quoi une closure ?', response: 'Une fonction + son scope', theme: 'javascript', tags: [], createdAt: new Date().toISOString(), updatedAt: new Date().toISOString() },
+  {
+    id: '1',
+    question: 'Cest quoi un commit ?',
+    response: 'Un snapshot du projet',
+    theme: 'git',
+    tags: [],
+    createdAt: new Date('2026-01-01T08:00:00Z'),
+    updatedAt: new Date('2026-01-01T08:00:00Z'),
+  },
+  {
+    id: '2',
+    question: 'Cest quoi une closure ?',
+    response: 'Une fonction + son scope',
+    theme: 'javascript',
+    tags: [],
+    createdAt: new Date('2026-01-01T08:00:00Z'),
+    updatedAt: new Date('2026-01-01T08:00:00Z'),
+  },
 ]
 
 beforeEach(() => {
@@ -45,7 +61,7 @@ it('affiche un lien vers le détail de chaque carte', async () => {
   expect(link).toHaveAttribute('href', '/cards/1')
 })
 
-it("affiche le thème de chaque carte", async () => {
+it('affiche le thème de chaque carte', async () => {
   vi.mocked(cardsApi.list).mockResolvedValue(CARDS)
   render(<CardList />)
   const item = (await screen.findByText('Cest quoi un commit ?')).closest('li')
diff --git a/src/components/card-list.tsx b/src/components/card-list.tsx
index 777a77a..575b6e9 100644
--- a/src/components/card-list.tsx
+++ b/src/components/card-list.tsx
@@ -1,3 +1,5 @@
+'use client'
+
 import Link from 'next/link'
 import { useEffect, useState } from 'react'
 import { ApiClientError, cardsApi } from '@/lib/api-client'
@@ -39,7 +41,11 @@ export function CardList() {
   }, [])
 
   if (error) {
-    return <p role="alert" className="text-red-600">{error}</p>
+    return (
+      <p role="alert" className="text-red-600">
+        {error}
+      </p>
+    )
   }
   if (cards === null) {
     return <p aria-busy="true">Chargement…</p>
diff --git a/src/lib/api-client.test.ts b/src/lib/api-client.test.ts
index a64a5eb..63ab202 100644
--- a/src/lib/api-client.test.ts
+++ b/src/lib/api-client.test.ts
@@ -22,10 +22,7 @@ beforeEach(() => {
 })
 
 function expectRequest(method: string, path: string) {
-  expect(fetchMock).toHaveBeenCalledWith(
-    path,
-    expect.objectContaining({ method }),
-  )
+  expect(fetchMock).toHaveBeenCalledWith(path, expect.objectContaining({ method }))
 }
 
 describe('cardsApi', () => {
@@ -43,8 +40,10 @@ describe('cardsApi', () => {
 
   it('create() envoie POST avec un corps JSON', async () => {
     fetchMock.mockResolvedValue(jsonResponse(CARD, 201))
-    await expect(cardsApi.create({ question: 'Q ?', response: 'R', theme: 'git' } as never)).resolves.toEqual(CARD)
-    const [_, init] = fetchMock.mock.calls[0]
+    await expect(
+      cardsApi.create({ question: 'Q ?', response: 'R', theme: 'git' } as never),
+    ).resolves.toEqual(CARD)
+    const [, init] = fetchMock.mock.calls[0]
     expect(init.method).toBe('POST')
     expect(JSON.parse(init.body)).toEqual({ question: 'Q ?', response: 'R', theme: 'git' })
   })
@@ -76,7 +75,9 @@ describe('cardsApi', () => {
   })
 
   it('lève ApiClientError avec le message de l API sur une erreur 404', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({ error: 'NotFoundError', message: 'Carte inconnue' }, 404))
+    fetchMock.mockResolvedValue(
+      jsonResponse({ error: 'NotFoundError', message: 'Carte inconnue' }, 404),
+    )
     await expect(cardsApi.get('nope')).rejects.toMatchObject({
       name: 'NotFoundError',
       message: 'Carte inconnue',
@@ -85,7 +86,9 @@ describe('cardsApi', () => {
   })
 
   it('lève ApiClientError sur une réponse invalide', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({ error: 'ValidationError', message: 'Payload invalide' }, 400))
+    fetchMock.mockResolvedValue(
+      jsonResponse({ error: 'ValidationError', message: 'Payload invalide' }, 400),
+    )
     await expect(cardsApi.create({} as never)).rejects.toBeInstanceOf(ApiClientError)
   })
 
diff --git a/src/lib/api-client.ts b/src/lib/api-client.ts
index 4d16270..2860cc4 100644
--- a/src/lib/api-client.ts
+++ b/src/lib/api-client.ts
@@ -29,7 +29,11 @@ async function request<T>(path: string, init?: RequestInit): Promise<T> {
   const body: T | ApiErrorPayload = await res.json().catch(() => ({}))
   if (!res.ok) {
     const payload = body as ApiErrorPayload
-    throw new ApiClientError(res.status, payload.error ?? 'HttpError', payload.message ?? `Erreur ${res.status}`)
+    throw new ApiClientError(
+      res.status,
+      payload.error ?? 'HttpError',
+      payload.message ?? `Erreur ${res.status}`,
+    )
   }
   return body as T
 }
@@ -37,7 +41,8 @@ async function request<T>(path: string, init?: RequestInit): Promise<T> {
 export const cardsApi = {
   list: () => request<Card[]>('/api/cards'),
   get: (id: string) => request<Card>(`/api/cards/${id}`),
-  create: (input: CardInput) => request<Card>('/api/cards', { method: 'POST', body: JSON.stringify(input) }),
+  create: (input: CardInput) =>
+    request<Card>('/api/cards', { method: 'POST', body: JSON.stringify(input) }),
   update: (id: string, input: CardInput) =>
     request<Card>(`/api/cards/${id}`, { method: 'PUT', body: JSON.stringify(input) }),
   remove: (id: string) => request<void>(`/api/cards/${id}`, { method: 'DELETE' }),